DCC Schema Refresh Fix #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fact that DCC doesn't handle varints.
| @@ -4,20 +4,20 @@ | |||
| <parent> | |||
| <groupId>io.debezium</groupId> | |||
| <artifactId>debezium-parent</artifactId> | |||
| <version>1.5.0-SNAPSHOT</version> | |||
| <version>1.5.0.Final</version> | |||
There was a problem hiding this comment.
Not sure why these .Finals are showing up as diff - they are the same on the target branch.
| @@ -71,6 +71,8 @@ private CassandraTypeConverter() { | |||
| typeMap.put(DataType.Name.TUPLE, new TupleTypeConverter()); | |||
| typeMap.put(DataType.Name.UDT, new UserTypeConverter()); | |||
| typeMap.put(DataType.Name.UUID, new BasicTypeConverter<>(UUIDType.instance)); | |||
| typeMap.put(DataType.Name.VARINT, new BasicTypeConverter<>(IntegerType.instance)); | |||
There was a problem hiding this comment.
We're pretty confident in this side of the type conversion stuff - varint corresponds to IntegerType in the CQL code in C*.
src/main/java/io/debezium/connector/cassandra/SchemaProcessor.java
Outdated
Show resolved
Hide resolved
| @@ -80,6 +81,7 @@ private CassandraTypeDeserializer() { | |||
| tmp.put(DoubleType.class, new BasicTypeDeserializer(CassandraTypeKafkaSchemaBuilders.DOUBLE_TYPE)); | |||
| tmp.put(DecimalType.class, new BasicTypeDeserializer(CassandraTypeKafkaSchemaBuilders.DOUBLE_TYPE)); | |||
| tmp.put(Int32Type.class, new BasicTypeDeserializer(CassandraTypeKafkaSchemaBuilders.INT_TYPE)); | |||
| tmp.put(IntegerType.class, new BasicTypeDeserializer(CassandraTypeKafkaSchemaBuilders.LONG_TYPE)); | |||
There was a problem hiding this comment.
This is likely borked - I don't think a long will be able to hold bigger IntegerType values.
src/test/java/io/debezium/connector/cassandra/CommitLogProcessorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/debezium/connector/cassandra/CommitLogProcessorTest.java
Outdated
Show resolved
Hide resolved
…fact that DCC doesn't handle varints.
…ndra into 1.5 # Conflicts: # REPORT.adoc # src/main/java/io/debezium/connector/cassandra/SchemaProcessor.java # src/test/java/io/debezium/connector/cassandra/CommitLogProcessorTest.java # src/test/java/io/debezium/connector/cassandra/SnapshotProcessorTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a diff against a branch that I created by checking out the commit before Stefan's first one and then cherrypicking the other 2 subsequent commits to 1.5 made by Debezium Builder. I think that should give a good basis to see the changes.
We probably don't need to merge this PR. We can just use it as a locus for comments.